summaryrefslogtreecommitdiff
path: root/upb/pb/compile_decoder.c
diff options
context:
space:
mode:
authorJosh Haberman <jhaberman@gmail.com>2015-08-14 18:54:11 -0700
committerJosh Haberman <jhaberman@gmail.com>2015-08-14 18:54:11 -0700
commit146a9c22efac6cb746ef4024144f28af891dd2b4 (patch)
tree3e43d77eaa169772bd72e6dabfabf44b2e38f7c6 /upb/pb/compile_decoder.c
parent782670e6a3d924a66adf23c94732603103b97223 (diff)
Added lots of decoder tests and fixed lots of bugs.
Diffstat (limited to 'upb/pb/compile_decoder.c')
-rw-r--r--upb/pb/compile_decoder.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/upb/pb/compile_decoder.c b/upb/pb/compile_decoder.c
index 2828247..b75f45c 100644
--- a/upb/pb/compile_decoder.c
+++ b/upb/pb/compile_decoder.c
@@ -596,7 +596,12 @@ static void generate_msgfield(compiler *c, const upb_fielddef *f,
if (!sub_m) {
/* Don't emit any code for this field at all; it will be parsed as an
- * unknown field. */
+ * unknown field.
+ *
+ * TODO(haberman): we should change this to parse it as a string field
+ * instead. It will probably be faster, but more importantly, once we
+ * start vending unknown fields, a field shouldn't be treated as unknown
+ * just because it doesn't have subhandlers registered. */
return;
}
generated by cgit on debian on lair
contact matthew@masot.net with questions or feedback