summaryrefslogtreecommitdiff
path: root/upb/descriptor
diff options
context:
space:
mode:
authorJosh Haberman <jhaberman@gmail.com>2016-09-12 11:06:56 -0700
committerJosh Haberman <jhaberman@gmail.com>2016-09-12 11:06:56 -0700
commit5a49a3360598abbb2250bd5ebd01ed173a65f8ac (patch)
treed1f21edb5732580bb15a26918eb684d139528f89 /upb/descriptor
parentaf79bfb919694a58852685f36a46ff32e401b58c (diff)
Responded to CR comments.
Diffstat (limited to 'upb/descriptor')
-rw-r--r--upb/descriptor/reader.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/upb/descriptor/reader.c b/upb/descriptor/reader.c
index 2b9e0e9..e219f18 100644
--- a/upb/descriptor/reader.c
+++ b/upb/descriptor/reader.c
@@ -651,7 +651,6 @@ static void *msg_startext(void *closure, const void *hd) {
return r;
}
-#include <stdio.h>
static void *msg_startfield(void *closure, const void *hd) {
upb_descreader *r = closure;
r->f = upb_fielddef_new(&r->f);
@@ -667,6 +666,8 @@ static bool msg_endfield(void *closure, const void *hd) {
bool ok;
UPB_UNUSED(hd);
+ /* Oneof fields are added to the msgdef through their oneof, so don't need to
+ * be added here. */
if (upb_fielddef_containingoneof(r->f) == NULL) {
ok = upb_msgdef_addfield(m, r->f, &r->f, NULL);
UPB_ASSERT(ok);
generated by cgit on debian on lair
contact matthew@masot.net with questions or feedback