summaryrefslogtreecommitdiff
path: root/upb/decode.c
diff options
context:
space:
mode:
authorJoshua Haberman <jhaberman@gmail.com>2018-09-06 12:57:16 -0700
committerJoshua Haberman <jhaberman@gmail.com>2018-09-06 12:57:16 -0700
commitf7713ebc391d247617b0dff788a76e5c3383ae94 (patch)
tree3542a54abd18ed5d1eef586ac331b1d66f7c612e /upb/decode.c
parent694d51f4d6cb8adf4a2f7975e5bb899327875de7 (diff)
Changed C API to use inline functions and computed offsets.
Diffstat (limited to 'upb/decode.c')
-rw-r--r--upb/decode.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/upb/decode.c b/upb/decode.c
index 1e5a6bc..1f3e4d8 100644
--- a/upb/decode.c
+++ b/upb/decode.c
@@ -200,9 +200,19 @@ static void *upb_array_add(upb_array *arr, size_t elements) {
return ret;
}
+static size_t get_field_offset(const upb_decframe *frame,
+ const upb_msglayout_field *field) {
+ if (field->oneof_index == UPB_NOT_IN_ONEOF) {
+ return field->offset;
+ } else {
+ return frame->m->oneofs[field->oneof_index].data_offset;
+ }
+}
+
static upb_array *upb_getarr(upb_decframe *frame,
const upb_msglayout_field *field) {
UPB_ASSERT(field->label == UPB_LABEL_REPEATED);
+ UPB_ASSERT(field->oneof_index == UPB_NOT_IN_ONEOF);
return *(upb_array**)&frame->msg[field->offset];
}
@@ -237,7 +247,7 @@ static void upb_setoneofcase(upb_decframe *frame,
static char *upb_decode_prepareslot(upb_decstate *d, upb_decframe *frame,
const upb_msglayout_field *field) {
- char *field_mem = frame->msg + field->offset;
+ char *field_mem = frame->msg + get_field_offset(frame, field);
upb_array *arr;
if (field->label == UPB_LABEL_REPEATED) {
generated by cgit on debian on lair
contact matthew@masot.net with questions or feedback