Ported upb to C89, for greater portability.

A large part of this change contains surface-level
porting, like moving variable declarations to the
top of the block.

However there are a few more substantial things too:

- moved internal-only struct definitions to a separate
  file (structdefs.int.h), for greater encapsulation
  and ABI compatibility.

- removed the UPB_UPCAST macro, since it requires access
  to the internal-only struct definitions.  Replaced uses
  with calls to inline, type-safe casting functions.

- removed the UPB_DEFINE_CLASS/UPB_DEFINE_STRUCT macros.
  Class and struct definitions are now more explicit -- you
  get to see the actual class/struct keywords in the source.
  The casting convenience functions have been moved into
  UPB_DECLARE_DERIVED_TYPE() and UPB_DECLARE_DERIVED_TYPE2().

- the new way that we duplicate base methods in derived types
  is also more convenient and requires less duplication.
  It is also less greppable, but hopefully that is not
  too big a problem.

Compiler flags (-std=c89 -pedantic) should help to rigorously
enforce that the code is free of C99-isms.

A few functions are not available in C89 (strtoll).  There
are temporary, hacky solutions in place.

1 files changed, 41 insertions, 41 deletions

diff --git a/upb/bindings/lua/upb.h b/upb/bindings/lua/upb.h
index 99fe8fe..09ffaa9 100644
--- a/upb/bindings/lua/upb.h
+++ b/upb/bindings/lua/upb.h
@@ -15,14 +15,14 @@
 #include "upb/handlers.h"
 #include "upb/symtab.h"
 
-// Lua 5.1/5.2 compatibility code.
+/* Lua 5.1/5.2 compatibility code. */
 #if LUA_VERSION_NUM == 501
 
 #define lua_rawlen lua_objlen
 
-// Lua >= 5.2's getuservalue/setuservalue functions do not exist in prior
-// versions but the older function lua_getfenv() can provide 100% of its
-// capabilities (the reverse is not true).
+/* Lua >= 5.2's getuservalue/setuservalue functions do not exist in prior
+ * versions but the older function lua_getfenv() can provide 100% of its
+ * capabilities (the reverse is not true). */
 #define lua_getuservalue(L, index) lua_getfenv(L, index)
 #define lua_setuservalue(L, index) lua_setfenv(L, index)
 
@@ -40,33 +40,33 @@ int luaL_typerror(lua_State *L, int narg, const char *tname);
   if (!(predicate))               \
     luaL_error(L, "internal error: %s, %s:%d ", #predicate, __FILE__, __LINE__);
 
-// Function for initializing the core library.  This function is idempotent,
-// and should be called at least once before calling any of the functions that
-// construct core upb types.
+/* Function for initializing the core library.  This function is idempotent,
+ * and should be called at least once before calling any of the functions that
+ * construct core upb types. */
 int luaopen_upb(lua_State *L);
 
-// Gets or creates a package table for a C module that is uniquely identified by
-// "ptr".  The easiest way to supply a unique "ptr" is to pass the address of a
-// static variable private in the module's .c file.
-//
-// If this module has already been registered in this lua_State, pushes it and
-// returns true.
-//
-// Otherwise, creates a new module table for this module with the given name,
-// pushes it, and registers the given top-level functions in it.  It also sets
-// it as a global variable, but only if the current version of Lua expects that
-// (ie Lua 5.1/LuaJIT).
-//
-// If "false" is returned, the caller is guaranteed that this lib has not been
-// registered in this Lua state before (regardless of any funny business the
-// user might have done to the global state), so the caller can safely perform
-// one-time initialization.
+/* Gets or creates a package table for a C module that is uniquely identified by
+ * "ptr".  The easiest way to supply a unique "ptr" is to pass the address of a
+ * static variable private in the module's .c file.
+ *
+ * If this module has already been registered in this lua_State, pushes it and
+ * returns true.
+ *
+ * Otherwise, creates a new module table for this module with the given name,
+ * pushes it, and registers the given top-level functions in it.  It also sets
+ * it as a global variable, but only if the current version of Lua expects that
+ * (ie Lua 5.1/LuaJIT).
+ *
+ * If "false" is returned, the caller is guaranteed that this lib has not been
+ * registered in this Lua state before (regardless of any funny business the
+ * user might have done to the global state), so the caller can safely perform
+ * one-time initialization. */
 bool lupb_openlib(lua_State *L, void *ptr, const char *name,
                   const luaL_Reg *funcs);
 
-// Custom check/push functions.  Unlike the Lua equivalents, they are pinned to
-// specific types (instead of lua_Number, etc), and do not allow any implicit
-// conversion or data loss.
+/* Custom check/push functions.  Unlike the Lua equivalents, they are pinned to
+ * specific types (instead of lua_Number, etc), and do not allow any implicit
+ * conversion or data loss. */
 int64_t lupb_checkint64(lua_State *L, int narg);
 int32_t lupb_checkint32(lua_State *L, int narg);
 uint64_t lupb_checkuint64(lua_State *L, int narg);
@@ -84,8 +84,8 @@ void lupb_pushdouble(lua_State *L, double val);
 void lupb_pushfloat(lua_State *L, float val);
 void lupb_pushbool(lua_State *L, bool val);
 
-// Functions for getting/pushing wrappers to various types defined in the
-// core library.
+/* Functions for getting/pushing wrappers to various types defined in the
+ * core library. */
 void *lupb_refcounted_check(lua_State *L, int narg, const char *type);
 const upb_msgdef *lupb_msg_checkdef(lua_State *L, int narg);
 const upb_msgdef *lupb_msgdef_check(lua_State *L, int narg);
@@ -104,26 +104,26 @@ void lupb_symtab_pushwrapper(lua_State *L, const upb_symtab *s,
 void lupb_symtab_pushnewrapper(lua_State *L, const upb_symtab *s,
                                const void *ref_donor);
 
-// For constructing a new message.  narg is the Lua value for the MessageDef
-// object.
+/* For constructing a new message.  narg is the Lua value for the MessageDef
+ * object. */
 void lupb_msg_pushnew(lua_State *L, int narg);
 
-// Builds and returns a handlers object for populating a lupb_msg described by
-// the MessageDef at "narg".
-//
-// TODO(haberman): factor this so it doesn't have to take a lua_State.  We
-// should be able to generate message handlers for a upb_msgdef that can be used
-// across many Lua states, so we can shared JIT code across lua_States.
+/* Builds and returns a handlers object for populating a lupb_msg described by
+ * the MessageDef at "narg".
+ *
+ * TODO(haberman): factor this so it doesn't have to take a lua_State.  We
+ * should be able to generate message handlers for a upb_msgdef that can be used
+ * across many Lua states, so we can shared JIT code across lua_States. */
 const upb_handlers *lupb_msg_newwritehandlers(lua_State *L, int narg,
                                               const void *owner);
 
-// Registers a type with the given name, methods, and metamethods.
-// If "refcount_gc" is true, adds a __gc metamethod that does an unref.
-// Refcounted types must be allocated with lupb_refcounted_push[new]wrapper.
+/* Registers a type with the given name, methods, and metamethods.
+ * If "refcount_gc" is true, adds a __gc metamethod that does an unref.
+ * Refcounted types must be allocated with lupb_refcounted_push[new]wrapper. */
 void lupb_register_type(lua_State *L, const char *name, const luaL_Reg *m,
                         const luaL_Reg *mm, bool refcount_gc);
 
-// Checks the given upb_status and throws a Lua error if it is not ok.
+/* Checks the given upb_status and throws a Lua error if it is not ok. */
 void lupb_checkstatus(lua_State *L, upb_status *s);
 
-#endif  // UPB_LUA_UPB_H_
+#endif  /* UPB_LUA_UPB_H_ */