diff options
| author | Joshua Haberman <joshua@reverberate.org> | 2011-02-13 18:05:19 -0800 |
|---|---|---|
| committer | Joshua Haberman <joshua@reverberate.org> | 2011-02-13 18:05:19 -0800 |
| commit | 6881b2c5cb8b824b9c16a1e7e0035c6dfb874a4c (patch) | |
| tree | a35c603695161cadf7f42eb0b4a99a2cb3e96aa1 /src/upb_def.c | |
| parent | b037b3e8f79f60bef2b9450c2e7c29c2529214db (diff) | |
Added proper error about broken 0-values for enums.
Diffstat (limited to 'src/upb_def.c')
| -rw-r--r-- | src/upb_def.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/upb_def.c b/src/upb_def.c index 7e962c8..879f1e8 100644 --- a/src/upb_def.c +++ b/src/upb_def.c @@ -476,6 +476,12 @@ static upb_flow_t upb_enumdef_EnumValueDescriptorProto_value(void *_b, break; case GOOGLE_PROTOBUF_ENUMVALUEDESCRIPTORPROTO_NUMBER_FIELDNUM: b->number = upb_value_getint32(val); + if (b->number == 0) { + upb_seterr(&b->status, UPB_ERROR, + "Enums with a value of 0 are currently broken; see " + "http://code.google.com/p/upb/issues/detail?id=1."); + return UPB_BREAK; + } b->saw_number = true; break; default: |