diff options
author | Andres Noetzli <andres.noetzli@gmail.com> | 2018-10-01 10:06:38 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-10-01 10:06:38 -0700 |
commit | 48ea68aa581d492c48fe9e08b54e9ce26f3508b9 (patch) | |
tree | da50b320545331f2b3f7b8e3304c9d16b40c6c13 /src/preprocessing/passes/bv_eager_atoms.cpp | |
parent | 5a19b4d2d2fce73b0d29ff3d40d52c7ef1f4246b (diff) |
Refactor preprocessing pass registration (#2468)
This commit refactors how preprocessing pass registration works,
inspired by LLVM's approach [0]. The basic idea is that every
preprocessing pass declares a static variable of type `RegisterPass` in
its source file that registers the pass with the
`PreprocessingPassRegistry` when starting the program. The registry is a
singleton that keeps track of all the available passes and allows other
code to create instances of the passes (note: previously the registry
itself was owning the passes but this is no longer the case). One of the
advantages of this solution is that we have a list of available passes
directly at the beginning of the program, which is useful for example
when parsing options.
As a side effect, this commit also fixes the SortInference pass, which
was expecting arguments other than the preprocessing pass context in its
constructor.
This commit is required for fixing dumping pre/post preprocessing
passes. It is also the ground work for allowing the user to specify a
preprocessing pipeline using command-line arguments.
[0] https://llvm.org/docs/WritingAnLLVMPass.html
Diffstat (limited to 'src/preprocessing/passes/bv_eager_atoms.cpp')
-rw-r--r-- | src/preprocessing/passes/bv_eager_atoms.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/preprocessing/passes/bv_eager_atoms.cpp b/src/preprocessing/passes/bv_eager_atoms.cpp index fe43ebcd0..6b80a4e65 100644 --- a/src/preprocessing/passes/bv_eager_atoms.cpp +++ b/src/preprocessing/passes/bv_eager_atoms.cpp @@ -18,6 +18,7 @@ #include "preprocessing/passes/bv_eager_atoms.h" +#include "preprocessing/preprocessing_pass_registry.h" #include "theory/theory_model.h" namespace CVC4 { @@ -42,6 +43,8 @@ PreprocessingPassResult BvEagerAtoms::applyInternal( return PreprocessingPassResult::NO_CONFLICT; } +static RegisterPass<BvEagerAtoms> X("bv-eager-atoms"); + } // namespace passes } // namespace preprocessing } // namespace CVC4 |