From 151ebc8a2925bca5210ac447156a6a783f1d9337 Mon Sep 17 00:00:00 2001
From: Joshua Haberman <jhaberman@gmail.com>
Date: Fri, 19 Apr 2019 16:19:57 -0700
Subject: Fixed oneof case accessor to cast to enum for C++.

---
 BUILD                    |   1 +
 tests/json/test.proto    |   5 +++++
 tests/json/test.proto.pb | Bin 1883 -> 1958 bytes
 tests/json/test_json.cc  |   1 +
 upbc/generator.cc        |   2 +-
 5 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/BUILD b/BUILD
index b54e0be..c700832 100644
--- a/BUILD
+++ b/BUILD
@@ -326,6 +326,7 @@ cc_test(
     ],
     deps = [
         ":test_json_upbprotoreflection",
+        ":test_json_upbproto",
         ":upb_json",
         ":upb_test",
     ],
diff --git a/tests/json/test.proto b/tests/json/test.proto
index e659001..2db0388 100644
--- a/tests/json/test.proto
+++ b/tests/json/test.proto
@@ -29,6 +29,11 @@ message TestMessage {
   map<string, int32>      map_string_int32 = 23;
   map<string, bool>       map_string_bool = 24;
   map<string, SubMessage> map_string_msg = 25;
+
+  oneof o {
+    int32 oneof_int32 = 26;
+    int64 oneof_int64 = 27;
+  }
 }
 
 message SubMessage {
diff --git a/tests/json/test.proto.pb b/tests/json/test.proto.pb
index 5da355d..94b8b92 100644
Binary files a/tests/json/test.proto.pb and b/tests/json/test.proto.pb differ
diff --git a/tests/json/test_json.cc b/tests/json/test_json.cc
index 3fddfb6..6650817 100644
--- a/tests/json/test_json.cc
+++ b/tests/json/test_json.cc
@@ -4,6 +4,7 @@
  */
 
 #include "tests/json/test.upbdefs.h"
+#include "tests/json/test.upb.h"   // Test that it compiles for C++.
 #include "tests/test_util.h"
 #include "tests/upb_test.h"
 #include "upb/handlers.h"
diff --git a/upbc/generator.cc b/upbc/generator.cc
index 2760069..5843597 100644
--- a/upbc/generator.cc
+++ b/upbc/generator.cc
@@ -362,7 +362,7 @@ void GenerateMessageInHeader(const protobuf::Descriptor* message, Output& output
         fullname);
     output(
         "UPB_INLINE $0_oneofcases $1_$2_case(const $1* msg) { "
-        "return UPB_FIELD_AT(msg, int, $3); }\n"
+        "return ($0_oneofcases)UPB_FIELD_AT(msg, int32_t, $3); }\n"
         "\n",
         fullname, msgname, oneof->name(),
         GetSizeInit(layout.GetOneofCaseOffset(oneof)));
-- 
cgit v1.2.3