From 17f0468c1656aa91d7cc5e3174a797312a9364c3 Mon Sep 17 00:00:00 2001 From: Andres Noetzli Date: Mon, 18 Nov 2019 12:28:54 -0800 Subject: Use -Wimplicit-fallthrough (#3464) This commit enables compiler warnings for implicit fallthroughs in switch statements that are not explicitly marked as such. The commit introduces a new macro `CVC4_FALLTHROUGH` that can be used to indicate that a fallthrough is intentional. The commit fixes existing warnings and a bug in the arithmetic rewriter for `abs` (the bug likely couldn't be triggered easily because we rewrite `abs` to an `ite` while expanding definitions). To have the new macro also available in the parser, the commit changes `src/base/check.h` to be visible to the parser (it includes `cvc4_private_library.h` now instead of `cvc4_private.h`). --- test/unit/theory/theory_arith_white.h | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'test/unit') diff --git a/test/unit/theory/theory_arith_white.h b/test/unit/theory/theory_arith_white.h index 235931efd..0e71fe911 100644 --- a/test/unit/theory/theory_arith_white.h +++ b/test/unit/theory/theory_arith_white.h @@ -323,5 +323,9 @@ public: TS_ASSERT_EQUALS(Rewriter::rewrite(leq0), Rewriter::rewrite(geq1.notNode())); TS_ASSERT_EQUALS(Rewriter::rewrite(leq1), Rewriter::rewrite(geq2.notNode())); + + // (abs x) --> (abs x) + Node absX = d_nm->mkNode(ABS, x); + TS_ASSERT_EQUALS(Rewriter::rewrite(absX), absX); } }; -- cgit v1.2.3