From 82c6aa2c8b9d73176ec958e4956e8dcbd4ae1b0f Mon Sep 17 00:00:00 2001
From: Andres Notzli <andres.noetzli@gmail.com>
Date: Thu, 22 Dec 2016 04:45:29 -0800
Subject: Avoid mixing new/delete with malloc/free

---
 proofs/lfsc_checker/check.cpp | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/proofs/lfsc_checker/check.cpp b/proofs/lfsc_checker/check.cpp
index 222c10615..05e12c0ad 100644
--- a/proofs/lfsc_checker/check.cpp
+++ b/proofs/lfsc_checker/check.cpp
@@ -941,15 +941,14 @@ void check_file(const char *_filename, args a, sccwriter* scw, libwriter* lw) {
   run_scc = a.run_scc;
   tail_calls = !a.no_tail_calls;
 
-
-  char *f;
+  std::string f;
   if (strcmp(_filename,"stdin") == 0) {
     curfile = stdin;
-    f = strdup(_filename);
+    f = std::string(_filename);
   }
   else {
     if (prev_curfile) {
-      f = strdup(prev_filename);
+      f = std::string(prev_filename);
 #ifdef _MSC_VER
 	    std::string str( f );
 	    for( int n=str.length(); n>=0; n-- ){
@@ -960,26 +959,26 @@ void check_file(const char *_filename, args a, sccwriter* scw, libwriter* lw) {
 	    }
 	    char *tmp = (char*)str.c_str();
 #else
-      char *tmp = dirname(f);
+      // Note: dirname may modify its argument, so we create a non-const copy.
+      char *f_copy = strdup(f.c_str());
+      std::string str = std::string(dirname(f_copy));
+      free(f_copy);
 #endif
-      delete f;
-      f = new char[strlen(tmp) + 10 + strlen(_filename)];
-      strcpy(f,tmp);
-      strcat(f,"/");
-      strcat(f,_filename);
+      f = str + std::string("/") + std::string(_filename);
     }
-    else
-      f = strdup(_filename);
-    curfile = fopen(f,"r");
+    else {
+      f = std::string(_filename);
+    }
+    curfile = fopen(f.c_str(), "r");
     if (!curfile)
       report_error(string("Could not open file \"")
-		   + string(f)
+		   + f
 		   + string("\" for reading.\n"));
   }
 
   linenum = 1;
   colnum = 1;
-  filename = f;
+  filename = f.c_str();
 
   char c;
   while ((c = non_ws()) && c!=EOF ) {
@@ -1286,7 +1285,6 @@ void check_file(const char *_filename, args a, sccwriter* scw, libwriter* lw) {
       }
     }
   }
-  free(f);
   if (curfile != stdin)
     fclose(curfile);
   linenum = prev_linenum;
-- 
cgit v1.2.3