summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-24CID 1362907: Initializing d_smtEngine to nullptr. (#1134)Tim King
2017-09-21Sygus inv templ refactor (#1110)Andrew Reynolds
* Decouple single invocation techniques from deep embedding techniques. Embed templates for invariant synthesis into grammar instead of as a global substitution. Add regression. * Update comment on class * Cleanup * Comments for sygus type construction.
2017-09-20Extend quantifier-free UF solver to higher-order. This includes an ex… (#1100)Andrew Reynolds
* Extend quantifier-free UF solver to higher-order. This includes an extensionality inference, and lazy conversion from APPLY_UF to HO_APPLY terms.Implements collectModelInfo and theory combination for HO_APPLY terms. * Update comments, minor changes to functions. Update APPLY_UF skolem to be user-context dependent. * Remove unused NodeList
2017-09-20Fix issue #1081, memory leak in cmd executor (#1109)Andres Noetzli
The variable `g` could be set multiple times depending on the options (e.g. a combination of `--dump-unsat-cores` and `--dump-synth`), which could lead to memory leaks and missing output. This commit fixes the issue by replacing `g` with a list of `getterCommands` that are all executed and deleted.
2017-09-19Add FP type enumerator and cardinality computer (#1104)Martin
2017-09-19Fixing a null pointer dereference in the cvc3 compatibility layer. (#1089)Tim King
2017-09-19Removing a potentially invalid comparison in the TPTP parser. (#1091)Tim King
2017-09-19Fix issue #1074, improve non-fatal error handling (#1075)Andres Noetzli
Commit 54d24c786d6a843cc72dfb5e377603349ea5e420 was changing CVC4 to handle certain non-fatal errors (such as calling get-unsat-core without a proceding unsat check-sat command) without terminating the solver. In the case of get-unsat-cores, the changes lead to the solver crashing because it was trying to print an unsat core initialized with the default constructor, so the member variable d_smt was NULL, which lead to a dereference of a null pointer. One of the issues of the way non-fatal errors were handled was that the error reporting was done in the invoke() method of the command instead of the printResult() method, which lead to the error described above and other issues such as a call to get-value printing a value after reporting an error. This commit aims to improve the design by adding a RecoverableModalException for errors that the solver can recover from and CommandRecoverableFailure to communicate that a command failed in a way that does not prohibit the solver from continuing to execute. The exception RecoverableModalException is thrown by the SMTEngine and the commands catch it and turn it into a CommandRecoverableFailure. The commit changes all error conditions from the commit above and adds a regression test for them.
2017-09-19Refactor cegqi instantiation infrastructure so that it is more independent ↵Andrew Reynolds
of instantiation for LIA. (#1111)
2017-09-18Fix issue #1105 involving string to int (#1112)Andrew Reynolds
This was introduced by changing the implementation of "isNumber" in this commit: a94318b This fixes issue #1105.
2017-09-18Floating point symfpu support (#1103)Martin
- Update the parser to the new constant construction - Fix the problem with parsing +/-zero and remove some dead code - Extend the interface for literal floating-point values. - Add a constructor so that a parameteric operator structure can be created from a type - Add constructors so parametric operator constants can be easily converted - Update SMT2 printing so that it uses the informative output
2017-09-17Moving the CVC4_PUBLIC attribute to the beginning of operator++. (#1107)Tim King
Removes the following warning when compiling with gcc version 4.8.4 : ../../../../../src/expr/kind_template.h:95:55: warning: '__visibility__' attribute ignored on non-class types [-Wattributes] Tested with clang-3.5.
2017-09-14Make floating-point comparison operators chainable (#1101)Martin
Floating-point comparison operators are chainable according to the standard.
2017-09-14Add missing CVC4_PUBLIC in kind_template (#1078)makaimann
2017-09-14Enable ccache compression, increase cache size (#1099)Andres Noetzli
This commit enables compression for ccache, increases the cache size to 1GB and resets the ccache statistics before each run.
2017-09-14Remove unhandled subtypes (#1098)Andrew Reynolds
* Remove unhandled subtypes, which consequently makes typing rules uniformly stricter based on weakening the subtype relation. Ensure coercions in the smt2 and cvc parser for Real decimal constants whose type is Integer. Ensure type annotations are computed during preRewrite to ensure rewriting (which does not preserve types) does not impact term construction for parametric datatypes. This fixes issue #1048 (we now give an type exception). * Update unit test for parametric datatypes to reflect new subtyping relation. * Remove deprecated test. * Make array construction for lambdas work with new subtype relations to handle lambdas like (lambda ((x Int) (y Int)) (ite (= x 0) 0.5 0.0)).
2017-09-14Simplifying the throw specifier of SmtEngine::checkSat and related calls to ↵Tim King
CVC4::Exception. (#1085)
2017-09-13Floating point symfpu support (#1093)Martin
Changes needed for the bit-blasting floating-point solver which are outside of it's area and / or applicable independently.
2017-09-13Add new kinds required for higher-order. (#1083)Andrew Reynolds
This consists of a binary apply symbol HO_APPLY that returns the result of applying its first argument to its second argument. Update the UF rewriter to ensure that non-standard APPLY_UF applications are rewritten into curried applications of HO_APPLY.
2017-09-13Add isConst check for lambda expressions. (#1084)Andrew Reynolds
Add isConst check for lambda expressions by conversions to and from an Array representation where isConst is implemented. This enables check-model to succeed on higher-order benchmarks. Change the builtin rewriter for lambda to attempt to put lambdas into constant form. Update regression.
2017-09-13Make ccache work with Clang on Travis (#1097)Andres Noetzli
This commit uses a workaround [0] to get ccache to work with Clang on Travis. [0] https://github.com/travis-ci/travis-ci/issues/5383#issuecomment-224630584
2017-09-13Modify equality engine to allow operators to be marked as external terms (#1082)Andrew Reynolds
This is required for reasoning higher-order, since we may have equalities between functions, which are operators of APPLY_UF terms. This commit gets around the previous 1% slowdown by modifying the changes to the equality engine to be minimal impact. Previously the "isInternal" flag could be reset to false after a term is marked as internal=true. This provides an interface for whether operators of a kind should be marked as internal=false from the start. When using higher-order, APPLY_UF operators will be marked as being external when the higher-order option ufHo is set to true. This has <.001% impact on performance on QF smtlib : https://www.starexec.org/starexec/secure/details/job.jsp?id=24445
2017-09-13Remove unused RecordSelect and TupleSelect (#1087)Andres Noetzli
Commit 62b673a6b8444c14c169a984dd6e3fc8f685851e remove most of the record/tuple infrastructure but did not remove the classes RecordSelect and TupleSelect which lead to issues with Java bindings (the references to the corresponding mkConst implementations could not be resolved). This commit removes the remaining traces of those classes.
2017-09-12Enable ccache on Travis, disable debug symbols (#1094)Andres Noetzli
Enable ccache on Travis for faster compile times. Also disable debug symbols for the debug builds on Travis to use the available cache more efficiently. Note: this change only works on GCC, support for Clang will require additional changes but the time savings should already be pretty significant.
2017-09-12Initial infrastructure for BV instantiation via word-level inversions. (#1056)Andrew Reynolds
* Initial infrastructure for BV instantiation via word-level inversions. * Minor clean up. * Change visited to unordered set.
2017-09-11Adding reasonable breaks in switch statement in ↵Tim King
TheoryStrings::normalizeRegexp. Minor code reorganization and applying clang-tidy to the function. (#1079)
2017-09-11Addressing a coverity scan complaint in theory_strings.cpp. I believe the ↵Tim King
root cause is that d_normal_forms_exp[r[0]] could have referred to different vectors (as operator[] is inserting for maps). (#1080)
2017-09-10Ensure that expand definitions is called on all non-variable expressi… (#1070)Andrew Reynolds
* Ensure that expand definitions is called on all non-variable expressions. In particular, it is necessary that the sets theory is notified when a set universe term occurs in the input to ensure options are set correctly. The commit moves this check from within check() to expandDefinitions(), and also adds the check for join image which relies on universe set. This fixes a bug reported by Arjun. Add and update regressions. * Add comments concerning expandDefinitions * Expand comment, move to .h
2017-09-07Properly handle user cardinality constraints for uf-ss=none. (#1068)Andrew Reynolds
2017-09-05Fix link in configure.ac.Mathias Preiner
2017-09-05Remove support for conversions between uint32/uint16 and string. (#1069)Andrew Reynolds
* Remove support for conversions between uint32/uint16 and string. * Temporarily disable regression.
2017-09-01Add travis debug build with cln. (#1066)Aina Niemetz
Until now, all travis builds where built with gmp. This commit adds an additional debug build built with cln.
2017-08-31Add GCC7 jobs to Travis (#1054)Andres Noetzli
This commit adds two jobs (debug, with portfolio, test groups 0 and 1) to Travis. Both jobs are added using matrix.include, based on the example in the documentation: https://docs.travis-ci.com/user/languages/cpp/#GCC-on-Linux . This unfortunately requires some code duplication but there does not seem to be a way to do it in a much better fashion.
2017-08-31Replace CVC4_THREADLOCAL in interactive_shell (#1065)Andres Noetzli
Commit 546d795470ca7c30fc62fe9b6c7b8e5838e1eed4 caused our nightly builds to fail because it did not replace CVC4_THREADLOCAL with CVC4_THREAD_LOCAL in interactive_shell. This commit fixes the issue and adds readline to Travis, s.t. readline related code gets compiled as part of our CI tests.
2017-08-31Answer unknown when uf-ss=no-minimal is combined with cardinality ↵Andrew Reynolds
constraints from user input, add regressions. (#1060)
2017-08-30Use thread_local instead of compiler extensions (#210)Andres Noetzli
C++11 introduced the thread_local keyword, so we don't need to use non-standard extensions or our custom pthread extension anymore. The behavior was previously introduced as a workaround in commit 753a072c542c1c254d7c6adbf10e091ba585ede5. This commit introduces the macro CVC4_THREAD_LOCAL that can be used to declare variables as thread local. For Swig, this macro is defined to be empty.
2017-08-30Fix model construction for parametric types (#1059)Andrew Reynolds
Fix model construction for parametric types so that we enumerate types in order of dependencies, and avoid subterms of previously enumerated values. There was a bug in model construction for parametric types which was related to enumerating values that are subterms of other previously enumerated values created during model construction (which were not recorded). This commit adds all subterms of values we enumerate to the "already used value" sets of their respective types, as reflected in the changes to TypeSet. There is an extra wrinkle in making the above change, which was caught by the regression test/regress/regress0/fmf/dt-proper-model.smt2. The issue is specific to finite model finding and can be corrected by ensuring that base types (e.g. uninterpreted sorts) are enumerated first. The change to TheoryModel::buildModel that replaces "allTypes" with "type_list" fixes this wrinkle. This constructs a partially ordered list of types where T1 comes before T2 if values of T2 can contain terms of type T1 but not vice versa. Ordering our enumeration in this way is probably a good idea in general. This ensures we enumerate values for equivalence classes of e.g. Int before (Array Int Int) and means we exclude fewer intermediate values during model construction.
2017-08-30Remove Coverity SSL certificate workaround from Travis configuration. (#1058)Mathias Preiner
Coverity works without the SSL certificate workaround and is not needed anymore. Note that we don't require sudo anymore and we could switch to container-based Travis builds (instead of VM-based). However, container-based environments only provide 4G of memory (instead of 7.5G for VMs) , which is not enough for the current CVC4 build environment.
2017-08-29Fix indentation for disabled Java tests.Mathias Preiner
2017-08-29Disable Java tests for now until they get fixed.Mathias Preiner
2017-08-28Run Ant on TravisPat Hawks
2017-08-28Travis: Package instead of download for cxxtest (#1055)Andres Noetzli
Before this commit, we were downloading cxxtest from Sourceforge. This commit instead installs the Ubuntu package, which is easier and more reliable. Instead of adding the package to the list of packages for Coverity and the common list of packages, this commit changes the Coverity package list to just refer to the common list of packages.
2017-08-25Move LFSC checker out of the CVC repository. (#222)Aina Niemetz
LFSC now lives outside of the CVC4 repository and is not part of the CVC4 distribution anymore. As a consequence, we + Add --with-lfsc and --with-lfsc-directory as configure options. In the case where CVC4 has not been built with integrated LFSC, all code that interacts with LFSC is disabled. + Disable proof checking if CVC4_USE_LFSC is not defined. Configuring the build with --check-proofs but without --with-lfsc results in an error. + Do not call LFSC's cleanup function (but we should in the future). LFSC checker segfaults during cleanup on regression testcase regress0/bv/core/bitvec7.smt. Disabled call to lfscc_cleanup until the problem in lfscc is fixed. + Disable building with LFSC for the distcheck travis build since it is not part of the distribution anymore. Further, make distcheck with LFSC would require to call contrib/get-lfsc-checker before calling make check on the temp build (the build of the unpacked distribution tar ball).
2017-08-25Added missing includes (algorithm).Aina Niemetz
Algorithm was previously removed from src/util/regexp.h which broke compilation on some platforms.
2017-08-24Test Java API on CIPat Hawks
2017-08-24Add include to fix buildAndres Noetzli
2017-08-24Merge pull request #191 from timothy-king/cleanup-regexpAndrew Reynolds
Cleaning up the CVC4::String class.
2017-08-23Fix typosAndres Noetzli
2017-08-23Removing TODO for 'Optimize via the iterator'. Not a priority. (#1051)Tim King
2017-08-21Cleanup: use Assert rather than C assert. (#1052)Aina Niemetz
generated by cgit on debian on lair
contact matthew@masot.net with questions or feedback