diff options
| author | Andres Noetzli <andres.noetzli@gmail.com> | 2018-10-02 10:28:38 -0700 |
|---|---|---|
| committer | Aina Niemetz <aina.niemetz@gmail.com> | 2018-10-02 10:28:38 -0700 |
| commit | 8519233cec9501f31aa1789eff60cb802c8df450 (patch) | |
| tree | 60c87d9fe4c59ac565b3fdd66710229f58bc6a44 /test/unit/util/integer_black.h | |
| parent | 64a0e3f1e4a5a8e3070eeadae0f6942b290c2974 (diff) | |
Fix "catching polymorphic type by value" warnings (#2556)
When using the `TS_ASSERT_THROWS` marco from CxxTest, we have to make
sure that we use a reference type for the exception, otherwise the unit
test tries to catch the exception by value, resulting in "catching
polymorphic type by value" warnings.
Diffstat (limited to 'test/unit/util/integer_black.h')
| -rw-r--r-- | test/unit/util/integer_black.h | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/test/unit/util/integer_black.h b/test/unit/util/integer_black.h index 6c183c972..9297429b4 100644 --- a/test/unit/util/integer_black.h +++ b/test/unit/util/integer_black.h @@ -293,14 +293,14 @@ public: } void testParseErrors() { - TS_ASSERT_THROWS(Integer("abracadabra"), std::invalid_argument); - TS_ASSERT_THROWS(Integer("+-1"), std::invalid_argument); - TS_ASSERT_THROWS(Integer("-+1"), std::invalid_argument); - TS_ASSERT_THROWS(Integer("5i"), std::invalid_argument); - TS_ASSERT_THROWS(Integer("10xyz"), std::invalid_argument); - TS_ASSERT_THROWS(Integer("0xff", 10), std::invalid_argument); - TS_ASSERT_THROWS(Integer("#x5", 0), std::invalid_argument); - TS_ASSERT_THROWS(Integer("0b123", 0), std::invalid_argument); + TS_ASSERT_THROWS(Integer("abracadabra"), std::invalid_argument&); + TS_ASSERT_THROWS(Integer("+-1"), std::invalid_argument&); + TS_ASSERT_THROWS(Integer("-+1"), std::invalid_argument&); + TS_ASSERT_THROWS(Integer("5i"), std::invalid_argument&); + TS_ASSERT_THROWS(Integer("10xyz"), std::invalid_argument&); + TS_ASSERT_THROWS(Integer("0xff", 10), std::invalid_argument&); + TS_ASSERT_THROWS(Integer("#x5", 0), std::invalid_argument&); + TS_ASSERT_THROWS(Integer("0b123", 0), std::invalid_argument&); } void testPow() { |