** Don't fear the files-changed list, almost all changes are in the **

** file-level documentation at the top of the sources.              **

This is the "make bugzilla stop bugging me" bugfix commit.

* Remove BackedNodeBuilder<> and collapse NodeBuilder<> hierarchy.
  Updated documentation in the file.  Resolves bug #99.

* Convenience NodeBuilders (PlusNodeBuilder, OrNodeBuilder, etc.)
  moved into a separate file.  Partially resolves bug #100.

* Moved isAssociative(Kind) into kind.h (and into the CVC4::kind
  namespace) instead of metakind.h (where it was in CVC4::metakind).
  This clears up a warning (private #inclusion) from the SMT and SMT2
  parsers, and maybe makes more sense anyways, since this is based on
  the kind (and not the metakind) of an operator.

* Documentation improvement; doxygen top-level \file gestures, \brief
  gestures for files, etc.  Changed contrib/update-copyright.pl for
  this change, and post-processed to add \brief.  Resolves bug #98.

* Removed ExprManager::mkExpr(Kind) and NodeManager::mkNode(Kind).
  They no longer made sense.  Resolves bug #91.

1 files changed, 7 insertions, 24 deletions

diff --git a/test/unit/expr/node_builder_black.h b/test/unit/expr/node_builder_black.h
index 8bde4b047..7f315f092 100644
--- a/test/unit/expr/node_builder_black.h
+++ b/test/unit/expr/node_builder_black.h
@@ -1,14 +1,17 @@
 /*********************                                                        */
-/** node_builder_black.h
+/*! \file node_builder_black.h
+ ** \verbatim
  ** Original author: taking
  ** Major contributors: mdeters
- ** Minor contributors (to current version): none
+ ** Minor contributors (to current version): dejan
  ** This file is part of the CVC4 prototype.
  ** Copyright (c) 2009, 2010  The Analysis of Computer Systems Group (ACSys)
  ** Courant Institute of Mathematical Sciences
  ** New York University
  ** See the file COPYING in the top-level source directory for licensing
- ** information.
+ ** information.\endverbatim
+ **
+ ** \brief Black box testing of CVC4::NodeBuilder.
  **
  ** Black box testing of CVC4::NodeBuilder.
  **/
@@ -20,6 +23,7 @@
 #include <sstream>
 
 #include "expr/node_builder.h"
+#include "expr/convenience_node_builders.h"
 #include "expr/node_manager.h"
 #include "expr/node.h"
 #include "expr/kind.h"
@@ -673,25 +677,4 @@ public:
     TS_ASSERT_EQUALS(Node(- a + b), d_nm->mkNode(PLUS, d_nm->mkNode(UMINUS, a), b));
     TS_ASSERT_EQUALS(Node(- a * b), d_nm->mkNode(MULT, d_nm->mkNode(UMINUS, a), b));
   }
-
-  /**
-   * This tests the "stack builder"
-   */
-  void testStackBuilder() {
-    try {
-      for(unsigned i = 0; i < 100; ++i) {
-        size_t n = 1 + (rand() % 50);
-
-        // make a builder "b" with a backing store for n children
-        makeStackNodeBuilder(b, n);
-
-        // build one-past-the-end
-        for(size_t j = 0; j <= n; ++j) {
-          b << d_nm->mkConst(true);
-        }
-      }
-    } catch(Exception e) {
-      std::cout << e;
-    }
-  }
 };