diff options
| author | Andres Noetzli <andres.noetzli@gmail.com> | 2018-10-02 10:28:38 -0700 |
|---|---|---|
| committer | Aina Niemetz <aina.niemetz@gmail.com> | 2018-10-02 10:28:38 -0700 |
| commit | 8519233cec9501f31aa1789eff60cb802c8df450 (patch) | |
| tree | 60c87d9fe4c59ac565b3fdd66710229f58bc6a44 /test/unit/expr/node_black.h | |
| parent | 64a0e3f1e4a5a8e3070eeadae0f6942b290c2974 (diff) | |
Fix "catching polymorphic type by value" warnings (#2556)
When using the `TS_ASSERT_THROWS` marco from CxxTest, we have to make
sure that we use a reference type for the exception, otherwise the unit
test tries to catch the exception by value, resulting in "catching
polymorphic type by value" warnings.
Diffstat (limited to 'test/unit/expr/node_black.h')
| -rw-r--r-- | test/unit/expr/node_black.h | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/test/unit/expr/node_black.h b/test/unit/expr/node_black.h index 461d59498..2415bd5e4 100644 --- a/test/unit/expr/node_black.h +++ b/test/unit/expr/node_black.h @@ -179,8 +179,8 @@ class NodeBlack : public CxxTest::TestSuite { #ifdef CVC4_ASSERTIONS // Basic bounds check on a node w/out children - TS_ASSERT_THROWS(Node::null()[-1], AssertionException); - TS_ASSERT_THROWS(Node::null()[0], AssertionException); + TS_ASSERT_THROWS(Node::null()[-1], AssertionException&); + TS_ASSERT_THROWS(Node::null()[0], AssertionException&); #endif /* CVC4_ASSERTIONS */ // Basic access check @@ -198,8 +198,8 @@ class NodeBlack : public CxxTest::TestSuite { #ifdef CVC4_ASSERTIONS // Bounds check on a node with children - TS_ASSERT_THROWS(ite == ite[-1], AssertionException); - TS_ASSERT_THROWS(ite == ite[4], AssertionException); + TS_ASSERT_THROWS(ite == ite[-1], AssertionException&); + TS_ASSERT_THROWS(ite == ite[4], AssertionException&); #endif /* CVC4_ASSERTIONS */ } @@ -420,8 +420,8 @@ class NodeBlack : public CxxTest::TestSuite { TS_ASSERT(f == fa.getOperator()); #ifdef CVC4_ASSERTIONS - TS_ASSERT_THROWS(f.getOperator(), IllegalArgumentException); - TS_ASSERT_THROWS(a.getOperator(), IllegalArgumentException); + TS_ASSERT_THROWS(f.getOperator(), IllegalArgumentException&); + TS_ASSERT_THROWS(a.getOperator(), IllegalArgumentException&); #endif /* CVC4_ASSERTIONS */ } @@ -459,10 +459,10 @@ class NodeBlack : public CxxTest::TestSuite { } #ifdef CVC4_ASSERTIONS - TS_ASSERT_THROWS(testNaryExpForSize(AND, 0), AssertionException); - TS_ASSERT_THROWS(testNaryExpForSize(AND, 1), AssertionException); - TS_ASSERT_THROWS(testNaryExpForSize(NOT, 0), AssertionException); - TS_ASSERT_THROWS(testNaryExpForSize(NOT, 2), AssertionException); + TS_ASSERT_THROWS(testNaryExpForSize(AND, 0), AssertionException&); + TS_ASSERT_THROWS(testNaryExpForSize(AND, 1), AssertionException&); + TS_ASSERT_THROWS(testNaryExpForSize(NOT, 0), AssertionException&); + TS_ASSERT_THROWS(testNaryExpForSize(NOT, 2), AssertionException&); #endif /* CVC4_ASSERTIONS */ } |