Public interface review items:

* Internal uses of CheckArgument changed to AssertArgument/AlwaysAssertArgument()
* Make util/Assert.h cvc4_private instead of public, so AssertionException and friends are now internal-only
* CheckArgument() throws non-AssertionException
* things outside the core library (parsers, driver) use regular C-style assert,
  or a public exception type.
* auto-generated documentation for Smt options and internal options

Also, a small fix to SMT-LIBv1 QF_ABV and QF_AUFBV definitions, which were nonstandard.

1 files changed, 5 insertions, 5 deletions

diff --git a/test/system/ouroborous.cpp b/test/system/ouroborous.cpp
index ac864d16b..daa7a9aae 100644
--- a/test/system/ouroborous.cpp
+++ b/test/system/ouroborous.cpp
@@ -72,8 +72,8 @@ string translate(string in, InputLanguage inlang, OutputLanguage outlang) {
   Expr e = psr->nextExpression();
   stringstream ss;
   ss << Expr::setlanguage(outlang) << Expr::setdepth(-1) << e;
-  AlwaysAssert(psr->nextExpression().isNull(), "next expr should be null");
-  AlwaysAssert(psr->done(), "parser should be done");
+  assert(psr->nextExpression().isNull());// next expr should be null
+  assert(psr->done());// parser should be done
   string s = ss.str();
   cout << "got this:" << endl
        << s << endl
@@ -81,7 +81,7 @@ string translate(string in, InputLanguage inlang, OutputLanguage outlang) {
 
   psr->setInput(Input::newStringInput(toInputLanguage(outlang), s, "internal-buffer"));
   Expr f = psr->nextExpression();
-  AlwaysAssert(e == f);
+  assert(e == f);
   cout << "got same expressions " << e.getId() << " and " << f.getId() << endl
        << "==============================================" << endl;
 
@@ -103,7 +103,7 @@ void runTestString(std::string instr, InputLanguage instrlang = input::LANG_SMTL
   string out = translate(cvc, input::LANG_CVC4, output::LANG_SMTLIB_V2);
   cout << "back to SMT2 : " << out << endl << endl;
 
-  AlwaysAssert(out == smt2, "differences in output");
+  assert(out == smt2);// differences in output
 }
 
 
@@ -121,7 +121,7 @@ int runTest() {
     delete c;
   }
 
-  AlwaysAssert(psr->done(), "parser should be done");
+  assert(psr->done());// parser should be done
 
   cout << Expr::setdepth(-1);