Minor fix in safe_print function

This commit fixes two issues reported by Coverity:

- Fixes the check whether the buffer is full in safe_print_hex
- Removes dead code in safe_print for floating-point values

Additionally, it fixes an issue reported by Andy where the names of the
statistics were printed as "<unsupported>" due to calling the const char*
version instead of the std::string version of safe_print.

Finally, this fixes an issue where --segv-spin would not print the program name
because it was a const char*. The program name is now stored as a string.

NOTE: As a side effect, the last part also fixes Coverity issue 1362944, which
has been in CVC4 for a long time.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/util/statistics.cpp b/src/util/statistics.cpp
index 73ea5b1b1..9423c9379 100644
--- a/src/util/statistics.cpp
+++ b/src/util/statistics.cpp
@@ -122,8 +122,8 @@ void StatisticsBase::safeFlushInformation(int fd) const {
   for (StatSet::iterator i = d_stats.begin(); i != d_stats.end(); ++i) {
     Stat* s = *i;
     if (d_prefix.size() != 0) {
-      safe_print(fd, d_prefix.c_str());
-      safe_print(fd, s_regDelim.c_str());
+      safe_print(fd, d_prefix);
+      safe_print(fd, s_regDelim);
     }
     s->safeFlushStat(fd);
     safe_print(fd, "\n");