diff options
| author | Andres Noetzli <andres.noetzli@gmail.com> | 2019-11-18 12:28:54 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-11-18 12:28:54 -0800 |
| commit | 17f0468c1656aa91d7cc5e3174a797312a9364c3 (patch) | |
| tree | 0c765c27541a3d0eed0e10b2afc49613e5c719ef /src/theory/uf | |
| parent | 6fe7877d82721e453d5d928a8fe9dbad2099dac1 (diff) | |
Use -Wimplicit-fallthrough (#3464)
This commit enables compiler warnings for implicit fallthroughs in
switch statements that are not explicitly marked as such. The commit
introduces a new macro `CVC4_FALLTHROUGH` that can be used to indicate
that a fallthrough is intentional. The commit fixes existing warnings
and a bug in the arithmetic rewriter for `abs` (the bug likely couldn't
be triggered easily because we rewrite `abs` to an `ite` while expanding
definitions).
To have the new macro also available in the parser, the commit changes
`src/base/check.h` to be visible to the parser (it includes
`cvc4_private_library.h` now instead of `cvc4_private.h`).
Diffstat (limited to 'src/theory/uf')
| -rw-r--r-- | src/theory/uf/symmetry_breaker.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/theory/uf/symmetry_breaker.cpp b/src/theory/uf/symmetry_breaker.cpp index 56d0c59cc..49ceebfd6 100644 --- a/src/theory/uf/symmetry_breaker.cpp +++ b/src/theory/uf/symmetry_breaker.cpp @@ -370,7 +370,7 @@ Node SymmetryBreaker::normInternal(TNode n, size_t level) { Debug("ufsymm:eq") << "UFSYMM " << n[0] << " <==> " << n[1] << endl; } } - /* intentional fall-through! */ + CVC4_FALLTHROUGH; case kind::XOR: // commutative binary operator handling return n[1] < n[0] ? NodeManager::currentNM()->mkNode(k, n[1], n[0]) : Node(n); |