diff options
author | Tim King <taking@cs.nyu.edu> | 2014-05-26 10:12:19 -0400 |
---|---|---|
committer | Tim King <taking@cs.nyu.edu> | 2014-05-26 10:12:19 -0400 |
commit | 29744e3da7abba18ca58f6a21ff2f5c300fbe241 (patch) | |
tree | 9527573092746c3298b139e6565985bc1f1a1ba6 /src/theory/theory.cpp | |
parent | 9d3f97ea91ffbf9ceea5814281a4d434d8e09a53 (diff) |
Fixing a soundness bug due to the default implmentation of Theory::ppAssert() not respecting subtyping.
Diffstat (limited to 'src/theory/theory.cpp')
-rw-r--r-- | src/theory/theory.cpp | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/theory/theory.cpp b/src/theory/theory.cpp index f65e48ec2..2dd474a19 100644 --- a/src/theory/theory.cpp +++ b/src/theory/theory.cpp @@ -210,11 +210,15 @@ void Theory::computeRelevantTerms(set<Node>& termSet) const Theory::PPAssertStatus Theory::ppAssert(TNode in, SubstitutionMap& outSubstitutions) { if (in.getKind() == kind::EQUAL) { - if (in[0].isVar() && !in[1].hasSubterm(in[0])) { + // (and (= x t) phi) can be replaced by phi[x/t] if + // 1) x is a variable + // 2) x is not in the term t + // 3) x : T and t : S, then S <: T + if (in[0].isVar() && !in[1].hasSubterm(in[0]) && (in[1].getType()).isSubtypeOf(in[0].getType()) ){ outSubstitutions.addSubstitution(in[0], in[1]); return PP_ASSERT_STATUS_SOLVED; } - if (in[1].isVar() && !in[0].hasSubterm(in[1])) { + if (in[1].isVar() && !in[0].hasSubterm(in[1]) && (in[0].getType()).isSubtypeOf(in[1].getType())){ outSubstitutions.addSubstitution(in[1], in[0]); return PP_ASSERT_STATUS_SOLVED; } |