diff options
| author | Andrew Reynolds <andrew.j.reynolds@gmail.com> | 2020-05-19 21:48:01 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-19 21:48:01 -0500 |
| commit | af874a5c7a2ff134da0d4c20d06a0626d3e36d9b (patch) | |
| tree | 16ad9de2b0c5753d2cd4cd3fcdd43bf8fbd55a71 /src/theory/strings/theory_strings.h | |
| parent | 9712a20e6585728c7d0453e64e1e3b06a7d37b7f (diff) | |
Do not eliminate variables that are equal to unevaluatable terms (#4267)
When we eliminate a variable x -> v during simplification, it may be the case that v contains "unevaluated" operators like forall, choice, etc. Thus, we do not produce correct models for such inputs unless simplification is disabled.
This PR ensures we only eliminate variables when v contains only evaluated operators.
Additionally, the kinds registered as unevaluated were slightly modified so that when we are in a logic like QF_LIA, there are no registered unevaluated operators, hence the check above is unnecessary. This is to minimize the performance impact of this change.
Fixes #4500.
Diffstat (limited to 'src/theory/strings/theory_strings.h')
| -rw-r--r-- | src/theory/strings/theory_strings.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/theory/strings/theory_strings.h b/src/theory/strings/theory_strings.h index 2e78198e3..7c99b6968 100644 --- a/src/theory/strings/theory_strings.h +++ b/src/theory/strings/theory_strings.h @@ -108,6 +108,9 @@ class TheoryStrings : public Theory { const LogicInfo& logicInfo); ~TheoryStrings(); + /** finish initialization */ + void finishInit() override; + TheoryRewriter* getTheoryRewriter() override { return &d_rewriter; } void setMasterEqualityEngine(eq::EqualityEngine* eq) override; |