Add Valuation::getSatValue() so that theories can access the current

(propositional) assignment for theory atoms.

Fixed Debug/Trace as discussed in bug ticket #252 and on the mailing list.
This implementation leads to some compiler warnings in production builds,
but these will be corrected in coming days.  There appears to be a small
speedup in the parser as a result of this fix:

  http://goedel.cims.nyu.edu/regress-results/compare_jobs.php?job_id=1902&reference_id=1886&p=5

Cleaned up a few CD Boolean attribute things.

Various small fixes to coding guidelines / test coverage.

This commit:
* Resolves bug 252 (tracing not disabled in production builds)
* Resolves bug 254 (implement CDAttrHash<>::BitIterator::find())

1 files changed, 2 insertions, 3 deletions

diff --git a/src/prop/prop_engine.cpp b/src/prop/prop_engine.cpp
index 4939ecb43..d64aadc96 100644
--- a/src/prop/prop_engine.cpp
+++ b/src/prop/prop_engine.cpp
@@ -5,7 +5,7 @@
  ** Major contributors: cconway, dejan
  ** Minor contributors (to current version): taking
  ** This file is part of the CVC4 prototype.
- ** Copyright (c) 2009, 2010  The Analysis of Computer Systems Group (ACSys)
+ ** Copyright (c) 2009, 2010, 2011  The Analysis of Computer Systems Group (ACSys)
  ** Courant Institute of Mathematical Sciences
  ** New York University
  ** See the file COPYING in the top-level source directory for licensing
@@ -137,8 +137,7 @@ Result PropEngine::checkSat() {
 }
 
 Node PropEngine::getValue(TNode node) {
-  Assert(node.getKind() == kind::VARIABLE &&
-         node.getType().isBoolean());
+  Assert(node.getType().isBoolean());
   SatLiteralValue v = d_satSolver->value(d_cnfStream->getLiteral(node));
   if(v == l_True) {
     return NodeManager::currentNM()->mkConst(true);