diff options
| author | Alex Ozdemir <aozdemir@hmc.edu> | 2019-12-30 20:13:48 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-12-30 20:13:48 -0800 |
| commit | f10f495cbb3784cfed51779836f49f7a06b4f289 (patch) | |
| tree | 7be96f4fa2a07b6bd0dbcc6dad735d313da29f21 /src/proof/arith_proof.cpp | |
| parent | b3471b719f1cd031d35e9a431027088b0dec156b (diff) | |
[proof] ITE translation fix (#3484)
* Bugfix: convert ifte arms to formulas for printing
We have two kinds of ITEs in our LFSC proofs:
* ite: for sort-typed expressions
* ifte: for formulas
Say that we have a Bool-sorted ITE. We had machinery for emitting an
`ifte` for it, but this machinery didn't actually convert the arms of
the ITE into formulas... Facepalm.
Fixed now.
* Test the lifting of ITEs from arithmetic.
This test verifies that booleans ITEs are correctly lifted to formula
ITEs in LRA proofs.
It used to fail, but now passes.
* clang-format
* Typos.
* Add test to CMake
* Set --check-proofs in test
* Address Yoni
* Expand printsAsBool documentation
* Assert ITE typing soundness
* Assert a subtype relation for ITEs, not equality
* Update src/proof/arith_proof.h
Thanks Yoni!
Co-Authored-By: yoni206 <yoni206@users.noreply.github.com>
Co-authored-by: yoni206 <yoni206@users.noreply.github.com>
Diffstat (limited to 'src/proof/arith_proof.cpp')
| -rw-r--r-- | src/proof/arith_proof.cpp | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/proof/arith_proof.cpp b/src/proof/arith_proof.cpp index 77f4b1630..ba38a314c 100644 --- a/src/proof/arith_proof.cpp +++ b/src/proof/arith_proof.cpp @@ -1193,4 +1193,11 @@ void LFSCArithProof::printAliasingDeclarations(std::ostream& os, std::ostream& p // Nothing to do here at this point. } +bool LFSCArithProof::printsAsBool(const Node& n) +{ + // Our boolean variables and constants print as sort Bool. + // All complex booleans print as formulas. + return n.getType().isBoolean() and (n.isVar() or n.isConst()); +} + } /* CVC4 namespace */ |