* Addressed issues brought up in Chris's review of Morgan's

  NodeManager (bug #65).  Better documentation, etc.

* As part of this, removed NodeManager::mkVar() (which created a
  variable of unknown type).  This requires changes to lots of unit
  tests, which were using this function.

* Performed some review of parser code (my code review #73).

  + I changed the way exceptions were caught and rethrown in
    src/parser/input.cpp.

  + ParserExceptions weren't being properly constructed (d_line and
    d_column weren't intiialized and could contain junk, leading to
    weird error messages).  Fixed.

* Fix to the current working directory used by run_regression script.
  Makes exceptional output easier to match against (in expected error
  output).

* (configure.ac) Ensure that CFLAGS has -fexceptions in it, in case we
  compile any C code and don't use the C++ compiler.

1 files changed, 4 insertions, 4 deletions

diff --git a/src/parser/input.cpp b/src/parser/input.cpp
index 4d5f348d8..fd1a4cbd6 100644
--- a/src/parser/input.cpp
+++ b/src/parser/input.cpp
@@ -43,7 +43,7 @@ void Input::enableChecks() {
   d_parserState->enableChecks();
 }
 
-Command* Input::parseNextCommand() throw (ParserException) {
+Command* Input::parseNextCommand() throw(ParserException) {
   Debug("parser") << "parseNextCommand()" << std::endl;
   Command* cmd = NULL;
   if(!done()) {
@@ -54,14 +54,14 @@ Command* Input::parseNextCommand() throw (ParserException) {
       }
     } catch(ParserException& e) {
       d_parserState->setDone();
-      throw ParserException(e.toString());
+      throw;
     }
   }
   Debug("parser") << "parseNextCommand() => " << cmd << std::endl;
   return cmd;
 }
 
-Expr Input::parseNextExpression() throw (ParserException) {
+Expr Input::parseNextExpression() throw(ParserException) {
   Debug("parser") << "parseNextExpression()" << std::endl;
   Expr result;
   if(!done()) {
@@ -71,7 +71,7 @@ Expr Input::parseNextExpression() throw (ParserException) {
         d_parserState->setDone();
     } catch(ParserException& e) {
       d_parserState->setDone();
-      throw ParserException(e.toString());
+      throw;
     }
   }
   Debug("parser") << "parseNextExpression() => " << result << std::endl;