Remove links field in all toml files (#4201)

This includes:

All options pertaining to SMTEngine are now handled at the top of setDefaults.
smtlibStrict was deleted in favor of a script.
statsEveryQuery enables stats by modifying a public option function. This is a slight hack but this code will likely get refactored as well soon.
A few other changes:

Fix a bug in SMTEngine: defineFunction should finalize options.
Call setDefaults before initilizing the TheoryEngine and ProofManager. This is necessary so that the PROOF(...) macro works earlier during initialization.
The next step will be to remove the links infrastructure for the options infrastructure. This will enable further detangling of our options dependencies.

1 files changed, 0 insertions, 7 deletions

diff --git a/src/options/base_options.toml b/src/options/base_options.toml
index 43060bc54..65eeda3ae 100644
--- a/src/options/base_options.toml
+++ b/src/options/base_options.toml
@@ -99,7 +99,6 @@ header = "options/base_options.h"
   long       = "stats-every-query"
   type       = "bool"
   default    = "false"
-  links      = ["--stats"]
   read_only  = true
   help       = "in incremental mode, print stats after every satisfiability or validity query"
 
@@ -155,9 +154,3 @@ header = "options/base_options.h"
   notifies   = ["notifyPrintSuccess"]
   read_only  = true
   help       = "print the \"success\" output required of SMT-LIBv2"
-
-[[alias]]
-  category   = "regular"
-  long       = "smtlib-strict"
-  links      = ["--lang=smt2", "--output-lang=smt2", "--strict-parsing", "--default-expr-depth=-1", "--print-success", "--incremental", "--abstract-values"]
-  help       = "SMT-LIBv2 compliance mode (implies other options)"