More language bindings work:

* with a patched SWIG, the ocaml bindings build correctly.
** I will provide my patch to the SWIG dev team.
* fixed some class interfaces to play more nicely with SWIG.
* php, perl, tcl now work; examples added.
* improved binding module building and installation.

Also:

Stop #defining NULL ((void*) 0).  This has been in cvc4_public.h for
a long, long time, I forget why I added it in the first place, and
it's a very, very bad idea.  In C++, certain things are permitted
for NULL that aren't permitted for ((void*) 0), like for instance
implicit conversion to any pointer type.  We didn't see an issue
here (until now, when interfacing with SWIG), because GCC is usually
pretty smart at working around such a broken #definition of NULL.
But that's fragile.

New exception-free Command architecture.  Previously, some command
invocations were wrapped in a try {} catch() {} and printed out an
error.  This is much more consistent now.  Each Command invocation
results in a CommandStatus.  The status can be "unsupported",
"error", or "success" (these are each derived classes, though, not
strings, so that they can be easily printed in a language-specific
way... e.g., in SMT-LIBv2, they are printed in a manner consistent
with the spec, and "success" is not printed if the print-success
option is off.)  All Command functionality are now no-throw
functions, which @cconway reports is a Good Thing for Google
(where all C++ exceptions are suspect), and also I think is much
cleaner than the old way in this instance.

Added an --smtlib2 option that enables an "SMT-LIBv2 compliance
mode"---really it just sets a few other options like strictParsing,
inputLanguage, and printSuccess.  In the future we might put other
options into a compliance mode, or we might choose to make it the
default.

1 files changed, 5 insertions, 2 deletions

diff --git a/src/cvc4.i b/src/cvc4.i
index 7723aee6e..8505d5128 100644
--- a/src/cvc4.i
+++ b/src/cvc4.i
@@ -25,11 +25,14 @@ namespace std {
 // caml_invalid_argument and caml_flush, which breaks C++
 // standard headers; undo this damage
 //
-// Unfortunately, this doesn't happen early enough.  swig puts an
-// include <stdexcept> very early, which breaks linking due to a
+// Unfortunately, this code isn't inserted early enough.  swig puts
+// an include <stdexcept> very early, which breaks linking due to a
 // nonexistent std::caml_invalid_argument symbol.. ridiculous!
 //
 #ifdef SWIGOCAML
+#  if defined(flush) || defined(invalid_argument)
+#    error "flush" or "invalid_argument" (or both) is defined by the ocaml headers.  You must #undef it above before inclusion of <stdexcept>.
+#  endif /* flush */
 #  undef flush
 #  undef invalid_argument
 #endif /* SWIGOCAML */