diff options
author | Alex Ozdemir <aozdemir@hmc.edu> | 2020-07-20 13:21:06 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-07-20 13:21:06 -0700 |
commit | 614ad602bc1f895dad8eaa001a69a4211c5459d2 (patch) | |
tree | 73955680b2bbc777bedac0f85932a1a25ea3dabe | |
parent | 96c168b25d940ccbb20c80087bc17bf7687cc9ab (diff) |
Fix a deadlock in the signature tests. (#4772)
* wait() deadlocks if the OS pipe fills
* communicate() does not
This is essentially a duplicate of [this](https://github.com/CVC4/LFSC/pull/38).
-rwxr-xr-x | test/signatures/run_test.py | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/test/signatures/run_test.py b/test/signatures/run_test.py index ac14267e9..df612e20a 100755 --- a/test/signatures/run_test.py +++ b/test/signatures/run_test.py @@ -111,12 +111,11 @@ def main(): result = subprocess.Popen(cmd, stderr=subprocess.STDOUT, stdout=subprocess.PIPE) - code = result.wait() - if 0 != code: - stdout = result.stdout.read() + (stdout, _) = result.communicate() + if 0 != result.returncode: if stdout: print(stdout.decode()) - return code + return result.returncode if __name__ == '__main__': |